-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page title + favicon in API pages #6834
Comments
@sdktr want to try taking this on? I'm not really sure how involved it would be. |
While we're at it we should see if it's feasible to serve the GraphiQL UI's static resources locally (as opposed to via a CDN), to better support isolated NetBox deployments. |
@jeremystretch - I'm not sure there is a clean solution for that other than creating a pull request for graphene-django or forking it. Maybe it's possible to overwrite the path to the template and having a local version with the changes (local resources, favicon and title). But from my quick look any solution (including the above) would require monkey patching which seems like a bad idea. |
We're already subclassing the stock GraphQLView, so it should be pretty easy to swap in our own template. The template actually looks pretty minimal; should be easy to tweak. We just need to ensure we keep resources in sync for future releases; that will be the more tricky part. |
Ok, I've got the title and favicon sorted in #6847, and we should be able to bundle the necessary static resources using our existing workflow. Just need to sync with @thatmattlove to confirm. |
Closes #6834: Customize GraphiQL view
NetBox version
v3.0-beta1
Feature type
Change to existing functionality
Proposed functionality
Add a favicon to both GraphiQL workspace and REST API. Plus add a page title to the GraphiQL playground.
Use case
When testing Netbox API calls the tabs in a browser do not stand out very recognizable. The page title for the REST API pages reflects the path one is on. The GraphiQL playground has no title so it renders the full query URL in the tab title.
Database changes
N/A
External dependencies
N/A
The text was updated successfully, but these errors were encountered: