Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename RackGroup to Location #5895

Closed
jeremystretch opened this issue Feb 27, 2021 · 2 comments
Closed

Rename RackGroup to Location #5895

jeremystretch opened this issue Feb 27, 2021 · 2 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Rename the RackGroup model to Location (or some similarly generic term). This is a fairly substantial change, as it would entail renaming the model, database table, URLs, and REST API endpoints and serializers. We would also rename the rack_group field on the Rack model and add a location field to Device.

Justification

This change would be prudent to accommodate #4971, which seeks to support the direct assignment of devices to rack groups, in a scenario where rack groups are used primarily to subdivide a parent site (e.g. into rooms or floors) rather than to group racks.

@jeremystretch jeremystretch added type: housekeeping Changes to the application which do not directly impact the end user status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Feb 27, 2021
@ryanmerolle
Copy link
Contributor

People are already using RackGroups as such, so it seems only prudent to rename.

@jeremystretch
Copy link
Member Author

My only concern is that this could be a fairly disruptive change. It probably makes sense to retain the current related fields as read-only aliases of the new fields to support backward compatibility for all v2.11 releases. We could even go so far as replicating the API endpoints (to provide both /dcim/rack-groups/ and /dcim/locations/), though I'm not sure how complicated that becomes.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Mar 3, 2021
@jeremystretch jeremystretch added this to the v2.11 milestone Mar 3, 2021
@jeremystretch jeremystretch self-assigned this Mar 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Development

No branches or pull requests

2 participants