Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow filtering by content type identified as <app>.<model> string for custom fields #5848

Closed
fabi125 opened this issue Feb 22, 2021 · 0 comments
Closed

Allow filtering by content type identified as <app>.<model> string for custom fields #5848

fabi125 opened this issue Feb 22, 2021 · 0 comments
Assignees
@jeremystretch
Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@fabi125
Copy link
Contributor

fabi125 commented Feb 22, 2021

Environment

  • Python version: 3.6.5
  • NetBox version: 2.10.4

Proposed Functionality

/api/extras/custom-fields/ should allow filtering by content type identified as . string.

Right now this returns an error. Filtering by ID works.

Use Case

Bring it in line with other filtering for content types.

This might have been overlooked in #4897 or missed because this API got added later.

Database Changes

None.

External Dependencies

None.
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation type: feature Introduction of new functionality to the application labels Feb 24, 2021
@jeremystretch jeremystretch added beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Apr 13, 2021
@jeremystretch jeremystretch self-assigned this Apr 13, 2021
jeremystretch added a commit that referenced this issue Apr 13, 2021
@jeremystretch
Closes #5848: Filter custom fields by content type in format <app_lab…
e5602ab 
…el>.<model>
@jeremystretch jeremystretch mentioned this issue Apr 16, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremystretch @fabi125