Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for Webhooks #5610

Closed
fabi125 opened this issue Jan 11, 2021 · 2 comments
Closed

Add API for Webhooks #5610

fabi125 opened this issue Jan 11, 2021 · 2 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@fabi125
Copy link
Contributor

fabi125 commented Jan 11, 2021

Environment

  • Python version: 3.6.5
  • NetBox version: 2.10.3

Proposed Functionality

Expose the functionality that is currently available in the Admin UI under Extras -> Webhooks via the Rest API to be able to add/update/delete webhooks.

Use Case

We would like to store the webhook configuration in source control and configure Netbox via the API.

See also #5608.

Database Changes

None.

External Dependencies

None.

@DanSheps DanSheps added status: under review Further discussion is needed to determine this issue's scope and/or implementation type: feature Introduction of new functionality to the application labels Jan 13, 2021
@cpmills1975
Copy link
Contributor

If web hooks and custom fields are to be exposed via the API, should permissions be as well?

For what it is worth, if you went down the path of using the netbox-docker container, these could be delivered in code via a 'startup-script' injected in to the container when it is brought up - I am currently in the process of using an enormous collection of custom startup-scripts to migrate two NetBox instances in to one and these are all stored in my SCM.

@jeremystretch
Copy link
Member

If web hooks and custom fields are to be exposed via the API, should permissions be as well?

There's already a REST API endpoint for permissions.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Mar 8, 2021
@jeremystretch jeremystretch added this to the v2.11 milestone Mar 8, 2021
@jeremystretch jeremystretch self-assigned this Mar 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

4 participants