Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of virtual machines to the cluster detail page #5425

Closed
furlongm opened this issue Dec 8, 2020 · 7 comments
Closed

Add list of virtual machines to the cluster detail page #5425

furlongm opened this issue Dec 8, 2020 · 7 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@furlongm
Copy link

furlongm commented Dec 8, 2020

Environment

  • Python version: 3.6
  • NetBox version: 2.9.10

Proposed Functionality

Adding the list of virtual machines in a given cluster to the cluster detail page, underneath the list of host devices. Also, adding an "add virtual machine" button to that table to quickly add virtual machines to a cluster (as with the "add devices" button on the devices table).

Use Case

Having the list of virtual machines on the cluster page saves having to click the link to the virtual machines page every time you want to see the virtual machines within a cluster. This is a very common operation for us and one of the top complaints of our users.

Database Changes

None

External Dependencies

None

@DanSheps DanSheps added status: under review Further discussion is needed to determine this issue's scope and/or implementation type: feature Introduction of new functionality to the application labels Dec 8, 2020
@jeremystretch
Copy link
Member

Clusters can have two types of resources assigned to them: hosts and virtual machines. Currently, the cluster view shows only assigned hosts. We could also display virtual machines, however the pagination system can handle only one type of object. So, we would need to decide for which type of object we'd support pagination.

Typically what we do in that case is to show each type of child object in a separate tab. (You can see an example of this when viewing a prefix, which can have both child prefixes and IP addresses.) That seems like a reasonable approach in this case.

@furlongm
Copy link
Author

furlongm commented Dec 9, 2020

It doesn't look like the current device table has pagination?

@jeremystretch
Copy link
Member

If not, it should. (All tables should.)

@stale
Copy link

stale bot commented Jan 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our contributing guide.

@stale stale bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Jan 23, 2021
@furlongm
Copy link
Author

I implemented devices and virtual machines in separate tabs, but have not opened a PR. This is because It does exactly the opposite of the intention of the feature request - which was to reduce the number of clicks required to view the cluster details. Also, the resulting cluster detail page ends up pretty empty so it ends up showing less details about the cluster than previously, which also seems to run counter to the intention of the cluster detail page.

@stale stale bot removed the pending closure Requires immediate attention to avoid being closed for inactivity label Jan 26, 2021
@stale
Copy link

stale bot commented Mar 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our contributing guide.

@stale stale bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Mar 19, 2021
@jeremystretch jeremystretch added status: blocked Another issue or external requirement is preventing implementation and removed pending closure Requires immediate attention to avoid being closed for inactivity status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Mar 25, 2021
@jeremystretch
Copy link
Member

Marking this as blocked by the v2.12 UI work (#5893).

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: blocked Another issue or external requirement is preventing implementation labels Mar 29, 2021
@jeremystretch jeremystretch self-assigned this Mar 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants