Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require running the rq-worker process #3408

Closed
lampwins opened this issue Aug 7, 2019 · 0 comments
Closed

Require running the rq-worker process #3408

lampwins opened this issue Aug 7, 2019 · 0 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation type: feature Introduction of new functionality to the application
Milestone

Comments

@lampwins
Copy link
Contributor

lampwins commented Aug 7, 2019

Environment

  • Python version: 3.7
  • NetBox version: 2.6.2

Proposed Functionality

Require users to always enable and run the rqworker process as a part of their NetBox installation.

Because of the changes in 2.6 which required Redis and its related dependencies, most of this is just documentation to ensure the rqworker is always running and no longer an optional installation step.

That being said, there is some logic surrounding the WEBHOOKS_ENABLED setting that should be removed which conditionally adds django_rq to the list of installed apps.

Use Case

Making the rqworker process optional has turned out to cause a lot of trouble for new users and creates unnecessary conditional logic in the installation instructions.

Requiring the rqworker to be run, unifies NetBox installations and also opens the door to implementing more background processing features such as #2006, #3351, and more.

Database Changes

None

External Dependencies

Move django-rq to a required dependency. All others became required in 2.6.

@lampwins lampwins added status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation type: feature Introduction of new functionality to the application labels Aug 7, 2019
@lampwins lampwins added this to the v2.7 milestone Aug 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants