Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circuit Providers filter prefiled with Site #2923

Closed
jbakklund opened this issue Feb 21, 2019 · 1 comment · Fixed by #2928
Closed

Circuit Providers filter prefiled with Site #2923

jbakklund opened this issue Feb 21, 2019 · 1 comment · Fixed by #2928
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@jbakklund
Copy link

The Circuit Providers search filter should be blank by default.

Environment

  • Python version: 3.5.3
  • NetBox version: 2.5.7

Steps to Reproduce

  1. Go to Organization > Sites and make sure that there is at least one site registered
  2. Go to Circuits > Providers

Expected Behavior

The search form should be blank by default.

Observed Behavior

The search form input field for 'Site' show you the name of the site that comes first alphabetically. This issue seems to have some similarity to issue #2912.
@DanSheps
Copy link
Member

Took a look at this, and there are a couple ways this could be fixed:

  • Add null_label='' to the FilterChoiceField
  • Change it to a APIMultipleSelect

When looking at this, I also found a few forms that aren't using Select2.

@DanSheps DanSheps added type: bug A confirmed report of unexpected behavior in the application status: accepted This issue has been accepted for implementation labels Feb 22, 2019
DanSheps added a commit to DanSheps/netbox that referenced this issue Feb 22, 2019
@DanSheps
Fixes netbox-community#2923: Changes Site Filter on Provider List to …
3ffea43 
…APISelectMultiple
@DanSheps DanSheps mentioned this issue Feb 22, 2019
Merged
jeremystretch added a commit that referenced this issue Feb 22, 2019
@jeremystretch
Merge pull request #2928 from DanSheps/2923-changecircuitsitefiltermulti
d707844 
Fixes #2923: Changes Site on ProviderFilterForm to APISelectMultiple
jeremystretch added a commit that referenced this issue Feb 22, 2019
@jeremystretch
Changelog for #2923
8dfef83
@jeremystretch jeremystretch mentioned this issue Mar 11, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2923: Changes Site on ProviderFilterForm to APISelectMultiple DanSheps/netbox
2 participants
@DanSheps @jbakklund