-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Interface form_factor to type #2920
Comments
@jeremystretch I think we should we allow a period of backward compatibility in the API. Say go ahead and change the model field but in the API continue to allow the use of |
Yeah, I've been asking myself whether it's honestly worth the hassle. I suppose we could migrate the field name, then add a getter/setter named |
I've renamed |
Proposed Changes
Rename the
form_factor
field on the dcim.Interface model totype
, and update forms and serializers accordingly.Justification
"Form factor" is a misnomer given the field's purpose in conveying specific network technologies. For example, 100 Mbps and 1 Gbps Ethernet can both utilize the 8P8C copper form factor, but provide two different types of services and employ different wire protocols.
The text was updated successfully, but these errors were encountered: