Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface Type Addition: 1000Base-LX (GbE over fibre, non-modular) #17934

Closed
andytech77 opened this issue Nov 5, 2024 · 2 comments · Fixed by #18025
Closed

Interface Type Addition: 1000Base-LX (GbE over fibre, non-modular) #17934

andytech77 opened this issue Nov 5, 2024 · 2 comments · Fixed by #18025
Assignees
@jmcguir
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@andytech77
Copy link

NetBox version

v4.1.6

Feature type

Data model extension

Triage priority

N/A

Proposed functionality

I would like to request that 1000Base-LX be added as an interface type in the "Ethernet (fixed)" category, to support legacy devices with fixed (non-modular) fibre interfaces.

Use case

We deal with some legacy telco devices and media converters that have fixed 1000Base-LX fibre interfaces (i.e. not SFP or any other kind of modular interface).

Database changes

No response

External dependencies

No response
@andytech77 andytech77 added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Nov 5, 2024
@bctiemann bctiemann added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation complexity: low Requires minimal effort to implement and removed status: needs triage This issue is awaiting triage by a maintainer labels Nov 5, 2024
@bctiemann
Copy link
Contributor

This would not be a data model extension tbc, it just needs an entry to be added to the appropriate section of InterfaceTypeChoices.

@jmcguir
Copy link
Contributor

jmcguir commented Nov 8, 2024

@bctiemann I can take ownership of this and create a PR.

jmcguir pushed a commit to jmcguir/netbox that referenced this issue Nov 8, 2024
fix netbox-community#17934 adding fixed 1000based-LX
0d2760b
@bctiemann bctiemann added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Nov 8, 2024
@jmcguir jmcguir mentioned this issue Nov 8, 2024
Closed
jmcguir pushed a commit to jmcguir/netbox that referenced this issue Nov 15, 2024
fix netbox-community#17934 adding 1000base-LX
8fce02e
@jmcguir jmcguir mentioned this issue Nov 15, 2024
Merged
jeremystretch pushed a commit that referenced this issue Nov 21, 2024
@jmcguir
Interface type change fixing #17934 (#18025)
1e5d199 
* fix #17934 adding 1000base-LX

* add extra space

---------

Co-authored-by: Joel L. McGuire <[email protected]>
This was referenced Nov 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmcguir jmcguir

Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
3 participants
@bctiemann @jmcguir @andytech77