Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add concurrency group to CI to automatically cancel in-flight jobs when applicable #17795

Closed
DanSheps opened this issue Oct 17, 2024 · 0 comments · Fixed by #18042
Closed

Add concurrency group to CI to automatically cancel in-flight jobs when applicable #17795

DanSheps opened this issue Oct 17, 2024 · 0 comments · Fixed by #18042
Assignees
@DanSheps
Labels
netbox status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user

Comments

@DanSheps
Copy link
Member

Proposed Changes

Add Concurrency group to CI to automatically cancel in-flight jobs when applicable:

  • Push to branch
  • Push to pull request

Justification

Currently, when tests are running and there is a new push to the branch or PR the tests will continue. Adding a concurrency group will cancel the in-flight tests and run only the newest test.

This doesn't add much but will optimize our CI a little bit.
@DanSheps DanSheps added type: housekeeping Changes to the application which do not directly impact the end user status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Oct 17, 2024
@DanSheps DanSheps self-assigned this Oct 17, 2024
@jeremystretch jeremystretch added the netbox label Nov 1, 2024 — with Linear
@DanSheps DanSheps added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Nov 19, 2024
DanSheps added a commit that referenced this issue Nov 19, 2024
@DanSheps
Closes: #17795 - Add concurrency to CI
efa70c4
@DanSheps DanSheps mentioned this issue Nov 19, 2024
Merged
jeremystretch pushed a commit that referenced this issue Nov 19, 2024
@DanSheps
Closes: #17795 - Add concurrency to CI (#18042)
13bd2ed 
* Closes: #17795 - Add concurrency to CI

* Add comment to demonstrate functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanSheps DanSheps

Labels
netbox status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes: #17795 - Add concurrency to CI netbox-community/netbox
2 participants
@DanSheps @jeremystretch