Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BulkImport naming inconsistency #17752

Closed
wkoot opened this issue Oct 14, 2024 · 0 comments
Closed

BulkImport naming inconsistency #17752

wkoot opened this issue Oct 14, 2024 · 0 comments
Assignees
Labels
netbox status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone

Comments

@wkoot
Copy link

wkoot commented Oct 14, 2024

Proposed Changes

Either rename views.generic.BulkImportView to views.generic.ImportView, or alter the urlpatterns to name='*_bulk_import'.
For backwards compatability, the BulkView could be an alias or urlpattern name='*_import' could be supported until a next major release.

I believe that renaming the urlpattern is better, since an import action could add only a single object (i.e. with a plugin connecting to an external service).
In this case, the NetBoxModelImportForm should probably also be renamed to NetBoxModelBulkImportForm.

Justification

The current implementation is inconsistent; the other bulk urlpatterns are named _bulk_add, _bulk_edit, _bulk_rename and _bulk_delete.
See for instance netbox/dcim/urls.py and netbox/ipam/urls.py.

@wkoot wkoot added the type: housekeeping Changes to the application which do not directly impact the end user label Oct 14, 2024
@jeremystretch jeremystretch added the netbox label Nov 1, 2024 — with Linear
@jeremystretch jeremystretch self-assigned this Nov 21, 2024
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Nov 21, 2024
@jeremystretch jeremystretch added this to the v4.2 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
netbox status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Development

No branches or pull requests

2 participants