BulkImport naming inconsistency #17752
Labels
netbox
status: accepted
This issue has been accepted for implementation
type: housekeeping
Changes to the application which do not directly impact the end user
Milestone
Proposed Changes
Either rename
views.generic.BulkImportView
toviews.generic.ImportView
, or alter the urlpatterns toname='*_bulk_import'
.For backwards compatability, the
BulkView
could be an alias or urlpatternname='*_import'
could be supported until a next major release.I believe that renaming the urlpattern is better, since an import action could add only a single object (i.e. with a plugin connecting to an external service).
In this case, the
NetBoxModelImportForm
should probably also be renamed toNetBoxModelBulkImportForm
.Justification
The current implementation is inconsistent; the other bulk urlpatterns are named
_bulk_add
,_bulk_edit
,_bulk_rename
and_bulk_delete
.See for instance
netbox/dcim/urls.py
andnetbox/ipam/urls.py
.The text was updated successfully, but these errors were encountered: