Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotificationGroup.notify() does not capture static representation of associated object #17097

Closed
jeremystretch opened this issue Aug 7, 2024 · 0 comments
Closed

NotificationGroup.notify() does not capture static representation of associated object #17097

jeremystretch opened this issue Aug 7, 2024 · 0 comments
Assignees
@jeremystretch
Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@jeremystretch
Copy link
Member

Deployment Type

NetBox Cloud

NetBox Version

v4.1-beta1

Python Version

3.10

Steps to Reproduce

  1. Create a notification group
  2. Create an event rule (e.g. for object changes) targeting that notification group
  3. Trigger the event rule

Expected Behavior

The generated notification should include a static representation of the object (object_repr).

Observed Behavior

The notification's object_repr attribute is empty.
@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application status: accepted This issue has been accepted for implementation beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available labels Aug 7, 2024
@jeremystretch jeremystretch self-assigned this Aug 7, 2024
@arthanson arthanson mentioned this issue Aug 13, 2024
Closed
jeremystretch added a commit that referenced this issue Aug 14, 2024
@jeremystretch
Fixes #17097: Record static object representation when calling Notifi…
855a07c 
…cationGroup.notify()
@jeremystretch jeremystretch mentioned this issue Aug 14, 2024
Merged
jeremystretch added a commit that referenced this issue Aug 15, 2024
@jeremystretch
Fixes #17097: Record static object representation when calling `Notif…
dd3166a 
…icationGroup.notify()` (#17161)

* Fixes #17097: Record static object representation when calling NotificationGroup.notify()

* Redirect to notifications list when marking as read notifications for deleted objects

* Link to object in notifications dropdown only for non-destructive events
@jeremystretch jeremystretch mentioned this issue Sep 3, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeremystretch