-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSO icon is not centered when there is no text #17007
Labels
severity: low
Does not significantly disrupt application functionality, or a workaround is available
status: accepted
This issue has been accepted for implementation
type: bug
A confirmed report of unexpected behavior in the application
Comments
mcmehrtens
added
status: needs triage
This issue is awaiting triage by a maintainer
type: bug
A confirmed report of unexpected behavior in the application
labels
Jul 28, 2024
I'd love to fix this quickly myself. I've never contributed to an open-source project before! |
DanSheps
added
status: needs owner
This issue is tentatively accepted pending a volunteer committed to its implementation
and removed
status: needs triage
This issue is awaiting triage by a maintainer
labels
Aug 1, 2024
arthanson
added
the
severity: low
Does not significantly disrupt application functionality, or a workaround is available
label
Aug 2, 2024
Just want to double-check that I can open a PR for this :) |
@mcmehrtens yes, and thank you. Will assign to you. |
arthanson
added
status: accepted
This issue has been accepted for implementation
and removed
status: needs owner
This issue is tentatively accepted pending a volunteer committed to its implementation
labels
Aug 12, 2024
@mcmehrtens are you still planning to work on this issue? |
I'm so sorry, yes. I'll do it tonight. I was moving in to a new apartment last week :) |
mcmehrtens
added a commit
to mcmehrtens/netbox
that referenced
this issue
Aug 27, 2024
mcmehrtens
added a commit
to mcmehrtens/netbox
that referenced
this issue
Aug 27, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
severity: low
Does not significantly disrupt application functionality, or a workaround is available
status: accepted
This issue has been accepted for implementation
type: bug
A confirmed report of unexpected behavior in the application
Deployment Type
Self-hosted
NetBox Version
v4.0.8
Python Version
3.11
Steps to Reproduce
SOCIAL_AUTH_BACKEND_ATTRS
variable in the configuration directory to have an icon and an empty string as the text:Expected Behavior
The SSO button shows on the login screen with only a centered icon.
Note: in the image, the rulers are off by 0.5 pts due to aliasing.
Observed Behavior
The SSO button shows on the login screen with the icon noticeably off-center, due to a 5rem margin on the right of the icon.
The text was updated successfully, but these errors were encountered: