Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO icon is not centered when there is no text #17007

Closed
mcmehrtens opened this issue Jul 28, 2024 · 5 comments · Fixed by #17271
Closed

SSO icon is not centered when there is no text #17007

mcmehrtens opened this issue Jul 28, 2024 · 5 comments · Fixed by #17271
Assignees
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@mcmehrtens
Copy link
Contributor

mcmehrtens commented Jul 28, 2024

Deployment Type

Self-hosted

NetBox Version

v4.0.8

Python Version

3.11

Steps to Reproduce

  1. Set the SOCIAL_AUTH_BACKEND_ATTRS variable in the configuration directory to have an icon and an empty string as the text:
SOCIAL_AUTH_BACKEND_ATTRS = {
    "oidc": ("", "https://mehrtens-cc.pages.dev/netbox/netbox_sso_icon.svg"),
}
  1. Restart NetBox.

Expected Behavior

The SSO button shows on the login screen with only a centered icon.

image

Note: in the image, the rulers are off by 0.5 pts due to aliasing.

Observed Behavior

The SSO button shows on the login screen with the icon noticeably off-center, due to a 5rem margin on the right of the icon.

image
@mcmehrtens mcmehrtens added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Jul 28, 2024
@mcmehrtens
Copy link
Contributor Author

I'd love to fix this quickly myself. I've never contributed to an open-source project before!

@DanSheps DanSheps added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels Aug 1, 2024
@DanSheps DanSheps removed their assignment Aug 1, 2024
@arthanson arthanson added the severity: low Does not significantly disrupt application functionality, or a workaround is available label Aug 2, 2024
@mcmehrtens
Copy link
Contributor Author

Just want to double-check that I can open a PR for this :)

@arthanson
Copy link
Collaborator

@mcmehrtens yes, and thank you. Will assign to you.

@arthanson arthanson added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Aug 12, 2024
@jeremystretch
Copy link
Member

@mcmehrtens are you still planning to work on this issue?

@mcmehrtens
Copy link
Contributor Author

@mcmehrtens are you still planning to work on this issue?

I'm so sorry, yes. I'll do it tonight. I was moving in to a new apartment last week :)

mcmehrtens added a commit to mcmehrtens/netbox that referenced this issue Aug 27, 2024
mcmehrtens added a commit to mcmehrtens/netbox that referenced this issue Aug 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants