Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Map"-button on site addresses with multiple lines is extended #16452

Closed
RasmusThing opened this issue Jun 8, 2024 · 2 comments · Fixed by #16629
Closed

"Map"-button on site addresses with multiple lines is extended #16452

RasmusThing opened this issue Jun 8, 2024 · 2 comments · Fixed by #16629
Assignees
@jeremystretch
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application

Comments

@RasmusThing
Copy link

RasmusThing commented Jun 8, 2024 •
edited
Loading

Deployment Type

Self-hosted

NetBox Version

v4.0.5

Python Version

3.11

Steps to Reproduce

When an address is added to a site object in NetBox and the address contains new lines, the Map button is messed up.

Expected Behavior

In NetBox pre-version 4, the button height was normalized and in center.
image

Observed Behavior

Button height is extended and the text is not in center.
image
@RasmusThing RasmusThing added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Jun 8, 2024
@RasmusThing RasmusThing changed the title "Map It"-button on site addresses with multiple lines is extended "Map"-button on site addresses with multiple lines is extended Jun 8, 2024
@arthanson arthanson added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Jun 10, 2024
@arthanson arthanson removed their assignment Jun 10, 2024
@jeremystretch jeremystretch self-assigned this Jun 17, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Jun 17, 2024
jeremystretch added a commit that referenced this issue Jun 17, 2024
@jeremystretch
Fixes #16452: Fix sizing of buttons within object attribute panels
c8df05f
@jeremystretch jeremystretch mentioned this issue Jun 17, 2024
Merged
jeremystretch added a commit that referenced this issue Jun 17, 2024
@jeremystretch
Fixes #16452: Fix sizing of buttons within object attribute panels
6f35a2a
jeremystretch added a commit that referenced this issue Jun 18, 2024
@jeremystretch
Update changelog for #15348, #16416, #16444, #16450, #16452, #16460, #…
9d28af4 
…16512, #16542
@jeremystretch jeremystretch mentioned this issue Jun 24, 2024
Merged
@jbakklund
Copy link

The 'Map' button for GPS coordinates is still bigger than the other buttons in this view. It would look more consistent if this button also used the "btn-sm" class.

@goteamkor
Copy link

The 'Map' button for GPS coordinates is still bigger than the other buttons in this view. It would look more consistent if this button also used the "btn-sm" class.

#17353

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #16452: Fix sizing of buttons within object attribute panels netbox-community/netbox
5 participants
@arthanson @RasmusThing @jeremystretch @jbakklund @goteamkor