Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time in Change Log without timezone #16143

Closed
fixed77 opened this issue May 15, 2024 · 2 comments · Fixed by #16323
Closed

Time in Change Log without timezone #16143

fixed77 opened this issue May 15, 2024 · 2 comments · Fixed by #16323
Assignees
@Julio-Oliveira-Encora
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@fixed77
Copy link

fixed77 commented May 15, 2024

Deployment Type

Self-hosted

NetBox Version

v4.0.2

Python Version

3.10

Steps to Reproduce

  1. Set TIME_ZONE in configuration.py
  2. Make changes
  3. Go to Changelog

Expected Behavior

Time in Changlelog table and events in localtime

Observed Behavior

Time in Changlelog table and events in UTC
@fixed77 fixed77 added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels May 15, 2024
@DanSheps DanSheps added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels May 21, 2024
@DanSheps DanSheps removed their assignment May 21, 2024
@samk-acw
Copy link
Contributor

This seems to be a regression due to #15737, or a djanjo 5 side effect.

A potential fix is loading the TIME_ZONE preference and doing .astimezone() before any .isoformat() call. This appeared to work when testing for myself but not sure about any other implications

@Julio-Oliveira-Encora
Copy link
Contributor

Could you please assign it to me?

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 28, 2024
Merged
@arthanson arthanson mentioned this issue Jun 13, 2024
Closed
jeremystretch added a commit that referenced this issue Jun 14, 2024
@jeremystretch
Changelog for #13925, #14829, #15794, #16143, #16256, #16454
49971dd
@jeremystretch jeremystretch mentioned this issue Jun 24, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Julio-Oliveira-Encora Julio-Oliveira-Encora

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

16143 - Time in Change Log without timezone Julio-Oliveira-Encora/netbox
5 participants
@fixed77 @DanSheps @jeremystretch @samk-acw @Julio-Oliveira-Encora