Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a default template for ObjectChildrenView #16070

Closed
jeremystretch opened this issue May 9, 2024 · 0 comments · Fixed by #16071
Closed

Set a default template for ObjectChildrenView #16070

jeremystretch opened this issue May 9, 2024 · 0 comments · Fixed by #16071
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Set the default value for template_name on ObjectChildrenView to generic/object_children.html.

Justification

Many subclasses of this view use the generic template directly. Defining it as the default for the view obviates the need to define it explicitly on each subclass.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels May 9, 2024
@jeremystretch jeremystretch self-assigned this May 9, 2024
jeremystretch added a commit that referenced this issue May 9, 2024
@jeremystretch
Closes #16070: Set default template for ObjectChildrenView
fc8f8e8
@jeremystretch jeremystretch mentioned this issue May 9, 2024
Merged
jeremystretch added a commit that referenced this issue May 13, 2024
@jeremystretch
Closes #16070: Set default template for ObjectChildrenView
e0f138d
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #16070: Set default template for ObjectChildrenView netbox-community/netbox
1 participant
@jeremystretch