Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in IPRange model #16027

Closed
grncbg opened this issue May 8, 2024 · 0 comments · Fixed by #16028
Closed

Typo in IPRange model #16027

grncbg opened this issue May 8, 2024 · 0 comments · Fixed by #16028
Assignees
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@grncbg
Copy link
Contributor

grncbg commented May 8, 2024

Deployment Type

Self-hosted

NetBox Version

v4.0.0

Python Version

3.10

Steps to Reproduce

The error message is defined as "Ending address must be lower than ...", but I think the correct definition is "Ending address must be greater than ...".

# Check that the ending address is greater than the starting address
if not self.end_address > self.start_address:
raise ValidationError({
'end_address': _(
"Ending address must be lower than the starting address ({start_address})"
).format(start_address=self.start_address)
})

Expected Behavior

Ending address must be greater than the starting address ({start_address})

Observed Behavior

Ending address must be lower than the starting address ({start_address})

@grncbg grncbg added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels May 8, 2024
grncbg added a commit to grncbg/netbox that referenced this issue May 8, 2024
@jeremystretch jeremystretch assigned grncbg and unassigned abhi1693 May 8, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels May 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants