Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cached setmode.js is retained across upgrades, breaking dark mode support temporarily #16003

Closed
JohannesKreuzer opened this issue May 7, 2024 · 3 comments · Fixed by #16004
Closed

Cached setmode.js is retained across upgrades, breaking dark mode support temporarily #16003

JohannesKreuzer opened this issue May 7, 2024 · 3 comments · Fixed by #16004
Assignees
@jeremystretch
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@JohannesKreuzer
Copy link

Deployment Type

Self-hosted

NetBox Version

v4.0.0

Python Version

3.11

Steps to Reproduce

enable dark mode on a page. then navigate to another page.

Expected Behavior

Dark mode stays enabled.

Observed Behavior

Dark mode is automatically disabled and page is shown in bright mode again
@JohannesKreuzer JohannesKreuzer added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels May 7, 2024
@JohannesKreuzer
Copy link
Author

JohannesKreuzer commented May 7, 2024 •
edited
Loading

A clearing of the browser cache resolved the issue.

Remaining issue is that the setmode.js is not postpended by the version as query param and so it is cached across netbox upgrades, creating the issue when setmode.js changes in upgrades of netbox.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels May 7, 2024
@jeremystretch jeremystretch changed the title Dark mode not persitant Cached setmode.js is retained across upgrades, breaking dark mode support temporarily May 7, 2024
@arthanson
Copy link
Collaborator

@JohannesKreuzer can you please edit this bug report (title, reproduce steps) for the setmode.js issue as the current description / title is resolved.

@jeremystretch
Copy link
Member

@arthanson I just updated the title. Will knock this out in a minute.

jeremystretch added a commit that referenced this issue May 7, 2024
@jeremystretch
Fixes #16003: Enable cache busting on upgrade for setmode.js
05d527f
@jeremystretch jeremystretch mentioned this issue May 7, 2024
Merged
jeremystretch added a commit that referenced this issue May 7, 2024
@jeremystretch
Fixes #16003: Enable cache busting on upgrade for setmode.js
ccf3224
@tobiasge tobiasge mentioned this issue May 7, 2024
Closed
@jeremystretch jeremystretch mentioned this issue May 9, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #16003: Enable cache busting on upgrade for setmode.js netbox-community/netbox
3 participants
@arthanson @JohannesKreuzer @jeremystretch