Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/UX - Quicksearch field should not resize when clear button is displayed #15968

Closed
jsenecal opened this issue May 6, 2024 · 0 comments · Fixed by #16046
Closed

UI/UX - Quicksearch field should not resize when clear button is displayed #15968

jsenecal opened this issue May 6, 2024 · 0 comments · Fixed by #16046
Assignees
@jeremystretch
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@jsenecal
Copy link
Contributor

jsenecal commented May 6, 2024

Deployment Type

Self-hosted

NetBox Version

v4.0-beta2

Python Version

3.11

Steps to Reproduce

  1. Navigate to any page with a quick search
  2. Type text in quick search field
  3. Notice that the text field resizes due to the apparition of the clear button.
  4. Also notice that the button doesnt fade-in like it used to do.

This is a regression from the original quick-search field behavior in v3.x

IMHO This (amongst other things) makes v4.0 less polished.

Expected Behavior

Just like v3.7, the field should not resize, the icon should fade in.

Recording.2024-05-06.110519.mp4

Observed Behavior

Field jumps size, makes the user interface and experience feel a bit clunky.

Recording.2024-05-06.110346.mp4
@jsenecal jsenecal added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels May 6, 2024
@arthanson arthanson added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels May 6, 2024
@arthanson arthanson removed their assignment May 6, 2024
@jeremystretch jeremystretch self-assigned this May 8, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 8, 2024
jeremystretch added a commit that referenced this issue May 8, 2024
@jeremystretch
Fixes #15968: Avoid resizing quick search field to display clear button
621651e
jeremystretch added a commit that referenced this issue May 8, 2024
@jeremystretch
Fixes #15968: Avoid resizing quick search field to display clear button
dc043a4
@jeremystretch jeremystretch mentioned this issue May 8, 2024
Merged
jeremystretch added a commit that referenced this issue May 9, 2024
@jeremystretch
Fixes #15968: Avoid resizing quick search field to display clear button
e055e0a
@jeremystretch jeremystretch mentioned this issue May 9, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #15968: Avoid resizing quick search field to display clear button netbox-community/netbox
3 participants
@arthanson @jsenecal @jeremystretch