Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPN IKE policies exported CSV contains HTML code #15960

Closed
igsh667 opened this issue May 6, 2024 · 1 comment · Fixed by #15964
Closed

VPN IKE policies exported CSV contains HTML code #15960

igsh667 opened this issue May 6, 2024 · 1 comment · Fixed by #15964
Assignees
@jeremystretch
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@igsh667
Copy link

igsh667 commented May 6, 2024 •
edited by jeremystretch
Loading

Deployment Type

Self-hosted

NetBox Version

v3.7.7

Python Version

3.8

Steps to Reproduce

Export to CSV of IKE policies contains HTML code "<a href=..." in Proposals column.

Expected Behavior

Should not contain HTML code in exported file.

Observed Behavior

Contains HTML code in exported file.
@igsh667 igsh667 added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels May 6, 2024
@jeremystretch jeremystretch changed the title VPN IKE proposals exported CSV contains HTML code VPN IKE policies exported CSV contains HTML code May 6, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels May 6, 2024
@jeremystretch
Copy link
Member

There are a few instances where this happens because we're using the stock ManyToManyColumn instead of our own, which causes this issue:

  • Interface inventory_items
  • IPAddress nat_outside
  • IKEPolicy proposals
  • IPSecPolicy proposals
  • TunnelTermination ip_addresses

jeremystretch added a commit that referenced this issue May 6, 2024
@jeremystretch
Fixes #15960: Use internal ManyToManyColumn to ensure proper export b…
ba65ae7 
…ehavior
@jeremystretch jeremystretch mentioned this issue May 6, 2024
Merged
jeremystretch added a commit that referenced this issue May 6, 2024
@jeremystretch
Fixes #15960: Use internal ManyToManyColumn to ensure proper export b…
15cc50f 
…ehavior
@jeremystretch jeremystretch mentioned this issue May 6, 2024
Merged
jeremystretch added a commit that referenced this issue May 6, 2024
@jeremystretch
Fixes #15960: Use internal ManyToManyColumn to ensure proper export b…
b1cfbbc 
…ehavior
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #15960: Use internal ManyToManyColumn to ensure proper export behavior netbox-community/netbox
3 participants
@arthanson @jeremystretch @igsh667