Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit/Delete all when filtering with quick search selects all objects, not only the filtered objects #15852

Closed
DanSheps opened this issue Apr 25, 2024 · 1 comment
Closed

Edit/Delete all when filtering with quick search selects all objects, not only the filtered objects #15852

DanSheps opened this issue Apr 25, 2024 · 1 comment
Assignees
@jeremystretch
Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@DanSheps
Copy link
Member

Deployment Type

Self-hosted

NetBox Version

v4.0.0-beta2

Python Version

3.11

Steps to Reproduce

  1. Create dependant devices/interfaces in order to have a sufficiently long enough interface list (2k interfaces is safe)
  2. Filter interfaces with the quick search so that you return ~200
  3. Hit the "Select All" checkbox
  4. Prompt will come up with option to edit all interfaces returned as result of query

Expected Behavior

  • Query should report ~200 interfaces
  • Editing/Deleting should only delete the 200 interfaces

Observed Behavior

  • Query reports initial interface list count (~2000)
  • Editing/Deleting performs bulk action on all interfaces
@DanSheps DanSheps added type: bug A confirmed report of unexpected behavior in the application status: needs triage This issue is awaiting triage by a maintainer status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Apr 25, 2024
@DanSheps
Copy link
Member Author

This issue is present in any list view.

This is caused by the HTMX not refreshing the "all" option. This would require an OOB swap of that element to resolve when applying the quick search filter.

Also applies to pending PR for table column filtering as that

@DanSheps DanSheps assigned DanSheps and unassigned arthanson Apr 25, 2024
@DanSheps DanSheps added status: accepted This issue has been accepted for implementation beta Concerns a bug/feature in a beta release and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Apr 25, 2024
jeremystretch added a commit that referenced this issue May 1, 2024
@jeremystretch
Fixes #15852: Update total object counts when filtering object lists
715c477
@jeremystretch jeremystretch mentioned this issue May 1, 2024
Merged
jeremystretch added a commit that referenced this issue May 2, 2024
@jeremystretch
Fixes #15852: Update total object counts when filtering object lists (#…
17e6d10 
…15909)

* Fixes #15852: Update total object counts when filtering object lists

* Misc cleanup
jeremystretch added a commit that referenced this issue May 2, 2024
@jeremystretch
#15852: Hide count element for non-HTMX requests
f8eee45
jeremystretch added a commit that referenced this issue May 3, 2024
@jeremystretch
Changelog for #15630, #15802, #15831, #15852, #15915, #15942, #15944
b91741d
@jeremystretch jeremystretch mentioned this issue May 6, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arthanson @DanSheps @jeremystretch