Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text length can extend beyond the boundary of its container panel on a model's detail page #15760

Closed
atownson opened this issue Apr 17, 2024 · 3 comments
Assignees
Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application

Comments

@atownson
Copy link
Contributor

Deployment Type

Self-hosted

NetBox Version

v4.0-beta1

Python Version

3.10

Steps to Reproduce

Hey guys, I wanted to revisit #10596 for v4.0-beta1. It seems this behavior is the same when using Tabler. Thanks for your work.

  1. Create a custom field with a Type of Text for any given model.
  2. Add a value to any given instantiated model for the custom field that is rather long, say 100 characters.
  3. View the model's detail page and observe the value extends beyond the panel boundary, given the width of the webpage.

Expected Behavior

The horizontally-long text should either wrap or a scrollbar should be shown.

Observed Behavior

The text extends beyond the panel boundaries.
image

@atownson atownson added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Apr 17, 2024
@jeffgdotorg
Copy link
Contributor

Unless I've gone to a different URL (which I can't tell for sure since your screenshot is cropped pretty tightly), I'm unable to reproduce this as reported. The text wraps as expected for me.
image

Are we looking at the same thing?

@jeffgdotorg jeffgdotorg added the status: revisions needed This issue requires additional information to be actionable label Apr 18, 2024
@jeremystretch
Copy link
Member

In @atownson's example the string has no whitespace permitting a line wrap, so the text extends beyond the boundary of its container. We probably just need to tweak overflow behavior for the container.

@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation beta Concerns a bug/feature in a beta release topic: UI/UX User interface or user experience related work severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: revisions needed This issue requires additional information to be actionable status: needs triage This issue is awaiting triage by a maintainer labels Apr 19, 2024
@jeffgdotorg
Copy link
Contributor

Thanks Jeremy, good catch.

@jeremystretch jeremystretch self-assigned this Apr 19, 2024
@jeremystretch jeremystretch added status: blocked Another issue or external requirement is preventing implementation status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation status: blocked Another issue or external requirement is preventing implementation labels Apr 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

3 participants