Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove configuration parameters date & time formatting #15738

Closed
jeremystretch opened this issue Apr 16, 2024 · 0 comments
Closed

Remove configuration parameters date & time formatting #15738

jeremystretch opened this issue Apr 16, 2024 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Milestone
v4.0

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Remove the following configuration parameters:

  • DATE_FORMAT
  • DATETIME_FORMAT
  • SHORT_DATE_FORMAT
  • SHORT_DATETIME_FORMAT
  • SHORT_TIME_FORMAT
  • TIME_FORMAT

Justification

Per #15735, NetBox will now display all dates & times in ISO 8601 format consistently, regardless of configuration or locale. These configuration parameters are no longer needed.

Impact

As Django 5.0 and later enforces localization of dates & times by default, these settings generally have no effect anyway (as noted in #15618).
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior labels Apr 16, 2024
@jeremystretch jeremystretch added this to the v4.0 milestone Apr 16, 2024
@jeremystretch jeremystretch self-assigned this Apr 16, 2024
@jeremystretch jeremystretch mentioned this issue Apr 16, 2024
Closed
jeremystretch added a commit that referenced this issue Apr 17, 2024
@jeremystretch
Closes #15738: Remove configuration parameters date & time formatting
085b81e
@jeremystretch jeremystretch mentioned this issue Apr 17, 2024
Merged
jeremystretch added a commit that referenced this issue Apr 17, 2024
@jeremystretch
Closes #15738: Remove configuration parameters date & time formatting
157df06
@jeremystretch jeremystretch mentioned this issue May 6, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
1 participant
@jeremystretch