Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering providers by AS number does not work #15609

Closed
jeremystretch opened this issue Apr 3, 2024 · 0 comments · Fixed by #15610
Closed

Filtering providers by AS number does not work #15609

jeremystretch opened this issue Apr 3, 2024 · 0 comments · Fixed by #15610
Assignees
@jeremystretch
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@jeremystretch
Copy link
Member

Deployment Type

NetBox Cloud

NetBox Version

v3.7.4

Python Version

3.11

Steps to Reproduce

  1. Create an ASN with number 65001.
  2. Create a provider and assign it the ASN.
  3. Navigate to the providers list in the UI and select the "Filters" tab.
  4. Enter 65001 in the "ASN" field and submit.

Expected Behavior

Only the provider(s) to which the ASN has been assigned should be included in the filtered list.

Observed Behavior

The filter has no effect: all providers are included in the list. This is because ProviderFilterSet no longer has a filter for the legacy asn field, which was removed from the Provider model in NetBox v3.4.

The ASN field should be updated to use the asn_id filter, and should present the user with a dynamic selection field to choose from the existing ASN objects.
@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application status: accepted This issue has been accepted for implementation severity: low Does not significantly disrupt application functionality, or a workaround is available labels Apr 3, 2024
@jeremystretch jeremystretch self-assigned this Apr 3, 2024
jeremystretch added a commit that referenced this issue Apr 3, 2024
@jeremystretch
Fixes #15609: Fix filtering providers list by assigned ASN
05e1694
@jeremystretch jeremystretch mentioned this issue Apr 3, 2024
Merged
jeremystretch added a commit that referenced this issue Apr 4, 2024
@jeremystretch
Fixes #15609: Fix filtering providers list by assigned ASN
d9a7b4e
jeremystretch added a commit that referenced this issue Apr 4, 2024
@jeremystretch
Changelog for #14707, #15039, #15598, #15608, #15609
48a3f3c
@jeremystretch jeremystretch mentioned this issue Apr 4, 2024
Merged
This was referenced Apr 8, 2024
Closed
Closed
Closed
Closed
This was referenced Apr 8, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 9, 2024
Closed
Closed
Closed
Closed
Closed
Closed
JCWasmx86 pushed a commit to JCWasmx86/netbox that referenced this issue Apr 23, 2024
@jeremystretch @JCWasmx86
Fixes netbox-community#15609: Fix filtering providers list by assigne…
604753d 
…d ASN
JCWasmx86 pushed a commit to JCWasmx86/netbox that referenced this issue Apr 23, 2024
@jeremystretch @JCWasmx86
Changelog for netbox-community#14707, netbox-community#15039, netbox-…
bb28648 
…community#15598, netbox-community#15608, netbox-community#15609
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #15609: Fix filtering providers list by assigned ASN netbox-community/netbox
1 participant
@jeremystretch