Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CPAK and CVR form factor #1551

Closed
beufanet opened this issue Oct 2, 2017 · 6 comments
Closed

Add CPAK and CVR form factor #1551

beufanet opened this issue Oct 2, 2017 · 6 comments
Labels
type: feature Introduction of new functionality to the application

Comments

@beufanet
Copy link

beufanet commented Oct 2, 2017

Issue type : Feature request

Environment

  • Python version: 2.7.9
  • NetBox version: 2.1.5

Description

Add new form factors for interfaces

Cisco CPAK and CVR are proprietary form factor for 100G optics.

https://www.cisco.com/c/en/us/products/collateral/interfaces-modules/transceiver-modules/data_sheet_c78-728110.html

We use it for Cisco N77 and ASR module, and sometimes running CVR (CFP2 to CPAK adapter).

We propose this patch for the community ;)

PR to come
@beufanet
Copy link
Author

beufanet commented Oct 2, 2017

PR : https://github.com/digitalocean/netbox/pull/1552/files

@jeremystretch jeremystretch added the type: feature Introduction of new functionality to the application label Oct 6, 2017
@jeremystretch
Copy link
Member

According to the data sheet, the CVR is an adapter for the CPAK form factor, and not a form factor itself. I'll add CPAK as a 100GE form factor.

@jeremystretch
Copy link
Member

Also adding the CFP2 and CFP4 100GE form factors.

jeremystretch added a commit that referenced this issue Oct 9, 2017
@jeremystretch
Closes #1551: Added CPAK, CFP2, and CFP4 100GE interface form factors
960e1d4
@jeremystretch jeremystretch mentioned this issue Oct 9, 2017
Closed
@beufanet
Copy link
Author

So should I suggest another patch or you manage it ?

Thanks !

@jeremystretch
Copy link
Member

The CPAK form factor has been added and will be included in v2.2.0. CVR will not be added because it is not a type of interface.

@beufanet
Copy link
Author

Thanks !

@jeremystretch jeremystretch mentioned this issue Oct 12, 2017
Merged
lampwins pushed a commit to lampwins/netbox that referenced this issue Oct 13, 2017
@jeremystretch
Closes netbox-community#1551: Added CPAK, CFP2, and CFP4 100GE interf…
6a54c0a 
…ace form factors
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beufanet @jeremystretch