Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CustomField object_type to related_object_type #15357

Closed
jeremystretch opened this issue Mar 6, 2024 · 0 comments
Closed

Rename CustomField object_type to related_object_type #15357

jeremystretch opened this issue Mar 6, 2024 · 0 comments
Assignees
@jeremystretch
Labels
breaking change This change modifies or removes some previously documented functionality status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone
v4.0

Comments

@jeremystretch
Copy link
Member

jeremystretch commented Mar 6, 2024 •
edited
Loading

NetBox version

v3.7.3

Feature type

Change to existing functionality

Proposed functionality

Rename the object_type ForeignKey field on CustomField to related_object_type (or any better suggestion).

Use case

Following the renaming of the content_types ManyToManyField to object_types under #15277, the name object_type can now be quite confusing. (object_types defines the types of NetBox objects on which the field appears, whereas object_type indicates the model indicated by an object or multi-object field.) Renaming this field should help avoid user confusion.

Database changes

Rename the object_type ForeignKey field on the CustomField model (effecting a migration).

External dependencies

None
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application labels Mar 6, 2024
@jeremystretch jeremystretch added this to the v4.0 milestone Mar 6, 2024
@jeremystretch jeremystretch self-assigned this Mar 6, 2024
@jeremystretch jeremystretch changed the title Rename CustomField object_type to model Rename CustomField object_type to related_object_type Mar 6, 2024
jeremystretch added a commit that referenced this issue Mar 7, 2024
@jeremystretch
Closes #15357: Rename CustomField.object_type to related_object_type
380ac5c
@jeremystretch jeremystretch mentioned this issue Mar 7, 2024
Merged
jeremystretch added a commit that referenced this issue Mar 9, 2024
@jeremystretch
Closes #15357: Rename CustomField.object_type to related_object_type (#…
78dd652 
…15366)
jeremystretch added a commit that referenced this issue Mar 11, 2024
@jeremystretch
#15357: Rename CustomField object_type to related_object_type
21de3f9
@jeremystretch jeremystretch mentioned this issue May 6, 2024
Merged
@jeremystretch jeremystretch added the breaking change This change modifies or removes some previously documented functionality label May 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
breaking change This change modifies or removes some previously documented functionality status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
1 participant
@jeremystretch