Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit FilterSet definitions application-wide #15237

Closed
jeremystretch opened this issue Feb 23, 2024 · 0 comments
Closed

Audit FilterSet definitions application-wide #15237

jeremystretch opened this issue Feb 23, 2024 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v4.0

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Review all currently defined FilterSet classes and check for:

  • Missing filters
  • Inconsistent names or behavior
  • Suboptimal performance
  • Opportunities for code reduction

Justification

The FilterSet classes defined in NetBox have evolved organically over the past several years and we are overdue for a structured audit of the existing filter sets. This will help us identify inconsistent or suboptimal implementations, and may yield additional work to help standardize and shrink the code base.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Feb 23, 2024
@jeremystretch jeremystretch added this to the v4.0 milestone Feb 23, 2024
@jeremystretch jeremystretch self-assigned this Mar 5, 2024
This was referenced Mar 7, 2024
Merged
Closed
Merged
jeremystretch added a commit that referenced this issue Mar 12, 2024
@jeremystretch
Merge pull request #15369 from netbox-community/15237-audit-filtersets
2d4295e 
Closes #15237: Add tests for missing filters
@jeremystretch jeremystretch mentioned this issue May 6, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
1 participant
@jeremystretch