Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No error shown for duplicate component names in device type import #15185

Closed
candlerb opened this issue Feb 17, 2024 · 0 comments · Fixed by #15213
Closed

No error shown for duplicate component names in device type import #15185

candlerb opened this issue Feb 17, 2024 · 0 comments · Fixed by #15213
Assignees
@abhi1693
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@candlerb
Copy link
Contributor

Deployment Type

Self-hosted

NetBox Version

v3.7.2

Python Version

3.8

Steps to Reproduce

Go to Device Types > Import and paste in the following YAML

---
manufacturer: APC
model: AP7868-test
slug: apc-ap7868-test
u_height: 0
power-ports:
  - name: Power Port 1
    type: cs8365c
  - name: Power Port 2
    type: cs8365c
  - name: Power Port 2
    type: cs8365c

(trimmed from case in discussion #15182)

Expected Behavior

An error to be displayed (ideally identifying the duplicate component name)

Observed Behavior

Netbox silently returns to the import screen. There is no indication that there was an error, but the import does not complete.
@candlerb candlerb added the type: bug A confirmed report of unexpected behavior in the application label Feb 17, 2024
@abhi1693 abhi1693 added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available labels Feb 18, 2024
@abhi1693 abhi1693 self-assigned this Feb 21, 2024
@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Feb 21, 2024
abhi1693 added a commit that referenced this issue Feb 21, 2024
@abhi1693
fixed error display on parent import form #15185
2a14c13
@abhi1693 abhi1693 mentioned this issue Feb 21, 2024
Merged
jeremystretch added a commit that referenced this issue Feb 21, 2024
@abhi1693 @jeremystretch
Fixed error display on parent import form (#15213)
f14eac5 
* fixed error display on parent import form #15185

* Rename parent_form; handle errors assigned to __all__

---------

Co-authored-by: Jeremy Stretch <[email protected]>
jeremystretch added a commit that referenced this issue Feb 21, 2024
@jeremystretch
Changelog for #14064, #14689, #14966, #15101, #15185
580d417
@jeremystretch jeremystretch mentioned this issue Feb 21, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abhi1693 abhi1693

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed error display on parent import form netbox-community/netbox
2 participants
@candlerb @abhi1693