Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the device_role & device_role_id filters for devices #15099

Closed
jeremystretch opened this issue Feb 9, 2024 · 0 comments
Closed

Remove the device_role & device_role_id filters for devices #15099

jeremystretch opened this issue Feb 9, 2024 · 0 comments
Assignees
@jeremystretch
Labels
breaking change This change modifies or removes some previously documented functionality status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Milestone
v4.0

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Remove the following filters for devices:

  • device_role (replaced by role)
  • device_role_id (replaced by role_id)

Justification

The device_role field on the Device model was renamed to role under #6391 in NetBox v3.6. These filters were retained for backward compatibility through v3.7 but are now obsolete.

Impact

Any API consumers still using these filters will need to be updated to use the new filters listed above.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior labels Feb 9, 2024
@jeremystretch jeremystretch added this to the v4.0 milestone Feb 9, 2024
@jeremystretch jeremystretch mentioned this issue Feb 9, 2024
Closed
@jeremystretch jeremystretch self-assigned this Feb 9, 2024
jeremystretch added a commit that referenced this issue Feb 9, 2024
@jeremystretch
Closes #15099: Remove legacy device_role & device_role_id filters for…
d8c6dad 
… devices
@jeremystretch jeremystretch mentioned this issue May 6, 2024
Merged
@jeremystretch jeremystretch added the breaking change This change modifies or removes some previously documented functionality label May 9, 2024
@RevLaw RevLaw mentioned this issue May 29, 2024
Open
@Alef-Burzmali Alef-Burzmali mentioned this issue Jun 12, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
breaking change This change modifies or removes some previously documented functionality status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
1 participant
@jeremystretch