Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to create tunnel termination for virtual machine #14839

Closed
abhi1693 opened this issue Jan 18, 2024 · 2 comments · Fixed by #14995
Closed

Unable to create tunnel termination for virtual machine #14839

abhi1693 opened this issue Jan 18, 2024 · 2 comments · Fixed by #14995
Assignees
Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@abhi1693
Copy link
Member

Deployment Type

Self-hosted

NetBox Version

v3.7.1

Python Version

3.10

Steps to Reproduce

  1. Create tunel without any terminations at first
  2. In the tunnel creation form, choose the newly selected tunnel with type virtual machine and any of its interface

Expected Behavior

A termination for the virtual machine should be created

Observed Behavior

Error of the form is raised

Select a valid choice. That choice is not one of the available choices.

I have debugged this a bit further, the clean method sets the termination which is always picking the Device interface no matter the selection made for the VM. Furthermore, there is an issue with the selector which always remains set for device.

So clearly, any selection made for the VM does show up in the UI but is not taken forward in any requests.

@abhi1693 abhi1693 added the type: bug A confirmed report of unexpected behavior in the application label Jan 18, 2024
@abhi1693 abhi1693 added the severity: medium Results in substantial degraded or broken functionality for specfic workflows label Jan 18, 2024
@abhi1693
Copy link
Member Author

The selector issue can be fixed by adding the following in the init method

self.fields['parent'].widget.attrs['selector'] = 'virtualization.virtualmachine'

But I'm still unsure where the primary issue is coming from.

@abhi1693 abhi1693 added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Jan 18, 2024
@abhi1693
Copy link
Member Author

Another issue I have found is that the edit does not show the selected vm related options in the drop-down

@DanSheps DanSheps self-assigned this Jan 19, 2024
@DanSheps DanSheps added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Jan 19, 2024
jeremystretch pushed a commit that referenced this issue Feb 5, 2024
…e in addition to intially passed data. (#14995)

* Fixes: #14839 - Check for tunnel termination type in additional instances

* Incorporate recommended changes
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
2 participants