Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BootstrapMixin #14740

Closed
jeremystretch opened this issue Jan 8, 2024 · 0 comments
Closed

Remove BootstrapMixin #14740

jeremystretch opened this issue Jan 8, 2024 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v4.0

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Ditch the BootstrapMixin class that's currently used to facilitate custom form field styling. Now that FORM_RENDERER has been configured to look for custom templates (see #13064), the functionality provided by this class can be offloaded to custom templates.

Justification

This change will remove a lot of cruft from existing form classes.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Jan 8, 2024
@jeremystretch jeremystretch added this to the v4.0 milestone Jan 8, 2024
@jeremystretch jeremystretch mentioned this issue Jan 18, 2024
Merged
@jeremystretch jeremystretch self-assigned this Jan 19, 2024
jeremystretch added a commit that referenced this issue Jan 19, 2024
@jeremystretch
Closes #14740: Remove BootstrapMixin (#14841)
da085e6 
* Introduce custom form widget templates to apply CSS classes

* Apply both mandatory and optional CSS classes to form widgets

* Omit required & placeholder attrs

* Move annotation of field validation failures to CSS

* Remove BootstrapMixin class

* Remove obsolete ComponentTemplateImportForm class

* Remove obsolete custom forms for login & password change

* Clean up obsolete accommodations for 'required' widget attr
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
1 participant
@jeremystretch