Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove backward compatibility for importing process_webhook() #14658

Closed
jeremystretch opened this issue Jan 2, 2024 · 0 comments
Closed

Remove backward compatibility for importing process_webhook() #14658

jeremystretch opened this issue Jan 2, 2024 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Milestone
v4.0

Comments

@jeremystretch
Copy link
Member

Proposed Changes

extras.webhooks_worker.process_webhook() was renamed and moved to `extras.webhooks.send_webhook() in v3.7 under #14395, with backward compatibility being retained for importing the function from its previous location. This change removes that backward compatibility.

Justification

Removes obsolete code

Impact

Any plugins which utilize this function imported from its previous location & name will need to be updated to reference the new path. (This function is not supported for direct use by plugins, but we provided backward compatibility across v3.7 releases just in case.)
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior labels Jan 2, 2024
@jeremystretch jeremystretch added this to the v4.0 milestone Jan 2, 2024
@jeremystretch jeremystretch self-assigned this Jan 3, 2024
jeremystretch added a commit that referenced this issue Jan 3, 2024
@jeremystretch
Closes #14658: Remove backward compatibility for process_webhook()
4949068
@jeremystretch jeremystretch mentioned this issue Jan 3, 2024
Merged
jeremystretch added a commit that referenced this issue Jan 3, 2024
@jeremystretch
Closes #14658: Remove backward compatibility for process_webhook()
f09658b
jeremystretch added a commit that referenced this issue Jan 9, 2024
@jeremystretch
Closes #14658: Remove backward compatibility for process_webhook()
68da158
jeremystretch added a commit that referenced this issue Jan 10, 2024
@jeremystretch
Changelog for #14092, #14637, #14638, #14657, #14658, #14672
f819933
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
1 participant
@jeremystretch