-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add oidc to auth backends to clean up the display #14587
Comments
I would also prefer this, as some of our users don‘t know what a keycloak login is and some of our applications already use a term like „login by company ID“. Maybe a simple solution to these issues is to make |
I would suggest a new config option called |
I made these 2 fixes in my own fork. I'd be happy to submit a PR if this is accepted. develop...llamafilm:netbox:develop |
I don't think we would go with "REMOTE_AUTH_NAME" as you could enable more then 1 SSO provider that might be missing details and need to provide data. It might also be useful to be able to override provided defaults (maintainers will need to discuss) |
How would it be possible to enable more than one SSO provider? From what I can tell, |
* added oidc to auth list #14587 * Alphabetic ordering --------- Co-authored-by: Jeremy Stretch <[email protected]>
Proposed Changes
Add:
to the
AUTH_BACKEND_ATTRS
in netbox/netbox/authentication.pyJustification
Currently, the social auth displays the various SSO options under the login page. This uses the dict "AUTH_BACKEND_ATTRS" to translate the driver name (google-openidconnect for example) to a more user friendly name "Google".
Currently "oidc" is missing from this dict, which is the very basic level of openidconnect and if you need to connect to a non-listed driver when setting up social-auth it simply displays the driver name (oidc) instead of a more user friendly name,
The text was updated successfully, but these errors were encountered: