Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PostgreSQL indexes for all generic foreign key fields #14436

Closed
jeremystretch opened this issue Dec 5, 2023 · 0 comments
Closed

Add PostgreSQL indexes for all generic foreign key fields #14436

jeremystretch opened this issue Dec 5, 2023 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v3.7

Comments

@jeremystretch
Copy link
Member

Proposed Changes

For all GenericForeignKey (GFK) relationships in a model, a PostgreSQL index should be created for its two concrete fields (content type and ID).

Justification

Creating indexes for these fields enables optimized lookup of records by related object. (Django unfortunately does not create these indexes automatically.)
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Dec 5, 2023
@jeremystretch jeremystretch self-assigned this Dec 5, 2023
@jeremystretch jeremystretch added this to the v3.7 milestone Dec 7, 2023
jeremystretch added a commit that referenced this issue Dec 7, 2023
@jeremystretch
Closes #14436: Add PostgreSQL indexes for all GenericForeignKeys
20f0858
@jeremystretch jeremystretch mentioned this issue Dec 7, 2023
Merged
jeremystretch added a commit that referenced this issue Dec 7, 2023
@jeremystretch
Closes #14436: Add indexes for all GenericForeignKey fields (#14463)
b532435 
* Closes #14436: Add PostgreSQL indexes for all GenericForeignKeys

* Add note about GFK indexes to developer docs
jeremystretch added a commit that referenced this issue Dec 15, 2023
@jeremystretch
Changelog for #14147, #14424, #14436, #14458
3068f2a
@jeremystretch jeremystretch mentioned this issue Dec 29, 2023
Merged
@jeremystretch jeremystretch mentioned this issue Jan 29, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
1 participant
@jeremystretch