Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin panel bulk operations are broken #14392

Closed
abhi1693 opened this issue Nov 30, 2023 · 1 comment · Fixed by #14440
Closed

Admin panel bulk operations are broken #14392

abhi1693 opened this issue Nov 30, 2023 · 1 comment · Fixed by #14440
Assignees
@jeremystretch
Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@abhi1693
Copy link
Member

abhi1693 commented Nov 30, 2023 •
edited
Loading

NetBox version

v3.6.6

Python version

3.10

Steps to Reproduce

  1. Navigate to your admin panel at /admin
  2. Create a nonce object (values do not matter) at /admin/social_django/nonce/
  3. From the list page, try to perform a bulk operation on the selected (1 or many) objects

Expected Behavior

The bulk operation should not crash

Observed Behavior

Log:

<class 'ValueError'>

Field 'id' expected a number but got ''.

Python version: 3.8.10
NetBox version: 3.6.6
Plugins: 
  netbox_demo: 0.3.1

This issue was first seen at Onemind-Services-LLC/netbox-secrets#106 and the temporary fix can be implemented by any plugin developer. However, this will not fix other admin models registered on the backend like django-social-auth.

The issue was due to the implementation of #13963

Here is a potential fix if this issue is not resolved within the core for other plugin developers: Onemind-Services-LLC/netbox-secrets@768fc16
@abhi1693 abhi1693 added type: bug A confirmed report of unexpected behavior in the application severity: medium Results in substantial degraded or broken functionality for specfic workflows labels Nov 30, 2023
@kkthxbye-code
Copy link
Contributor

See also: netbox-community/netbox-topology-views#407

The clean fix for plugin authors is to just revert back to the normal form renderer:

https://github.com/mattieserver/netbox-topology-views/pull/408/files

@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Dec 5, 2023
@jeremystretch jeremystretch self-assigned this Dec 5, 2023
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Dec 5, 2023
jeremystretch added a commit that referenced this issue Dec 5, 2023
@jeremystretch
Fixes #14392: Fix admin UI bulk actions
76d2029
@jeremystretch jeremystretch mentioned this issue Dec 5, 2023
Merged
jeremystretch added a commit that referenced this issue Dec 7, 2023
@jeremystretch
Fixes #14392: Fix admin UI bulk actions
9d71922
jeremystretch added a commit that referenced this issue Dec 7, 2023
@jeremystretch
Changelog for #14249, #14390, #14392, #14397, #14401, #14432, #14448
2ef023a
@jeremystretch jeremystretch mentioned this issue Dec 15, 2023
Merged
@agusadjadj agusadjadj mentioned this issue Dec 21, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #14392: Fix admin UI bulk actions netbox-community/netbox
3 participants
@kkthxbye-code @abhi1693 @jeremystretch