Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a description field to the Webhook model #14361

Closed
jeremystretch opened this issue Nov 28, 2023 · 3 comments
Closed

Add a description field to the Webhook model #14361

jeremystretch opened this issue Nov 28, 2023 · 3 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@jeremystretch
Copy link
Member

NetBox version

v3.6.5

Feature type

Data model extension

Proposed functionality

Add a standard description field to the Webhook model.

Use case

This will enable users to record a brief description concerning the use of the webhook. This has become more important in the wake of #14267, which separates the event logic from the webhook definition using the new EventRule model.

Database changes

Add a new CharField

External dependencies

None

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application labels Nov 28, 2023
@jeremystretch jeremystretch added this to the v3.7 milestone Nov 28, 2023
jacobpfickes added a commit to jacobpfickes/netbox that referenced this issue Nov 29, 2023
jacobpfickes added a commit to jacobpfickes/netbox that referenced this issue Nov 29, 2023
@jacobpfickes
Copy link

I'd like to contribute to this issue

@jeremystretch jeremystretch self-assigned this Nov 29, 2023
@jeremystretch
Copy link
Member Author

@jacobpfickes I really appreciate the interest and normally I'd be happy to assign this to you, however we're in a bit of a time crunch right now as we need to release the v3.7 beta by end of week. There might also be some conflicts with other ongoing work that could complicate the PR process. So I'm going to knock this out myself real quick, but I encourage you to browse some of our other open issues to see if there's anything else you'd like to take on.

@jacobpfickes
Copy link

@jeremystretch Ok completely understand. I have a changes on my fork and ready to submit a PR right now if that helps. If not then no worries. It is my fault for not getting it assigned before working on it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants