Improve diffs for custom_fields

[JCWasmx86]

NetBox version

v3.6.5

Feature type

Change to existing functionality

Proposed functionality

Currently, if you change a custom field, the changelog shows the entire "block" of custom fields as added+removed. This makes comparing changes more difficult as there is a lot of stuff that didn't change.

I would implement it like that:

def make_diffs(old_data, new_data):
    added = {}
    removed = {}
    for k in old_data.keys():
        o_d = old_data[k]
        n_d = new_data[k]
        if o_d != n_d:
            if isinstance(o_d, dict) and isinstance(n_d, dict):
                sub_added, sub_removed = make_diffs(o_d, n_d)
                added[k] = sub_added
                removed[k] = sub_removed
            else:
                removed[k] = o_d
                added[k] = n_d
    return (added, removed)

Related to #12273, #10924, I would implement that.

Use case

• Reduces the amount of clutter
• Changes are more visible

Database changes

None

External dependencies

None

[jeremystretch]

This was initially proposed in #10924, which was closed out as stale having found no volunteer. @JCWasmx86 are you volunteering to own this implementation? If not, this can be closed out as a duplicate.

[JCWasmx86]

Yes, I would implement that