Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the ConfigRevision model from extras to core #14312

Closed
jeremystretch opened this issue Nov 21, 2023 · 0 comments
Closed

Move the ConfigRevision model from extras to core #14312

jeremystretch opened this issue Nov 21, 2023 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v3.7

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Move the ConfigRevision model and views from the extras app to the core app.

Justification

Unlike everything else in extras, the use of config revisions is not an optional extra feature, but rather a core component of NetBox. Additionally, relocating this model may help avoid confusion with NetBox's unrelated configuration rendering features.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Nov 21, 2023
@jeremystretch jeremystretch added this to the v3.7 milestone Nov 21, 2023
@jeremystretch jeremystretch self-assigned this Nov 21, 2023
This was referenced Nov 22, 2023
Closed
Merged
jeremystretch added a commit that referenced this issue Nov 27, 2023
@jeremystretch
Closes #14312: Move ConfigRevision to core (#14328)
975a647 
* Move ConfigRevision model & write migrations

* Move ConfigRevision resources from extras to core

* Extend migration to update original content type for ConfigRevision
@jeremystretch jeremystretch mentioned this issue Dec 7, 2023
Closed
@jeremystretch jeremystretch mentioned this issue Dec 29, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
1 participant
@jeremystretch