Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move L2VPN models to new vpn app #14311

Closed
jeremystretch opened this issue Nov 21, 2023 · 2 comments
Closed

Move L2VPN models to new vpn app #14311

jeremystretch opened this issue Nov 21, 2023 · 2 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v3.7

Comments

@jeremystretch
Copy link
Member

Proposed Changes

FR #9816 (VPN tunnel modeling) has introduced a new vpn app. This issue proposes moving the L2VPN and L2VPN Termination models and all their related resources from the ipam app to the vpn app.

Justification

There was discussion at the time when L2VPN support was being added about whether it made sense to create a new app for it. Although we opted not to at the time, it would be prudent to move these now as the vpn app is a much more suitable home for these models.

Unfortunately, this will effect a breaking change in the REST API, however it should be easily manageable.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Nov 21, 2023
@jeremystretch jeremystretch added this to the v3.7 milestone Nov 21, 2023
@jeremystretch jeremystretch self-assigned this Nov 21, 2023
@abhi1693
Copy link
Member

Will bookmarks remain unaffected?

@jeremystretch
Copy link
Member Author

I expect related objects, content types, etc. to all be unaffected; that's the plan at least. We've never actually moved a model between apps before IIRC, but I don't think it will be too disruptive.

This was referenced Nov 27, 2023
Merged
Merged
jeremystretch added a commit that referenced this issue Nov 28, 2023
@jeremystretch
Closes #14311: Move L2VPN models from ipam to vpn (#14358)
d2fea4e 
* Move L2VPN and L2VPNTermination models from ipam to vpn

* Move L2VPN resources from ipam to vpn

* Extend migration to update content types

* Misc cleanup
jeremystretch added a commit that referenced this issue Dec 4, 2023
@jeremystretch
#14311: Update model documentation
c0512e2
@jeremystretch jeremystretch mentioned this issue Dec 29, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
2 participants
@abhi1693 @jeremystretch