Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the field Facility to the Location model #13918

Closed
jsenecal opened this issue Sep 27, 2023 · 3 comments · Fixed by #15456
Closed

Add the field Facility to the Location model #13918

jsenecal opened this issue Sep 27, 2023 · 3 comments · Fixed by #15456
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@jsenecal
Copy link
Contributor

jsenecal commented Sep 27, 2023

NetBox version

v3.6.3

Feature type

Data model extension

Proposed functionality

Add the field facility to the Location model the same way it's done on the Site model

Use case

Most of the time the Facility is not a whole building but rather a Suite (Location) in a building (Site). You may also have more than one Facility inside the same Site or have a single facility in a suite in the building but also other tenants in their own Locations which are not part of that Facility.

For example:
151 Front St., Toronto, ON Canada; Canada's largest Carrier Hotel.
Equinix TR1: Suite 706
Neutral Data Toronto: Suite 800
BELL Canada: Suite 605
Coloware YTZ1: Suite 504
Cologix TOR1: Suite 602
eStruxture TOR-1: Suite 341
Aptum: Suite 402
... and many others

Being able to document this Facility name/ID in a consistent manner across NetBox seems only reasonable.

Database changes

A new CharField, facility needs to be added to the Location model.

We can use the Site model for reference.

External dependencies

None

@jsenecal jsenecal added the type: feature Introduction of new functionality to the application label Sep 27, 2023
@kmorin18
Copy link

Agreed, we have POPs in many locations where the location is a suite that acts as a Provider's facility

@jsenecal
Copy link
Contributor Author

FWIW I can submit a PR for this, if accepted.

@yash-pal1
Copy link
Contributor

@abhi1693 Can you please assign me this task i can able to do that

@jeremystretch jeremystretch added the needs milestone Awaiting prioritization for inclusion with a future NetBox release label Nov 6, 2023
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed needs milestone Awaiting prioritization for inclusion with a future NetBox release labels Mar 9, 2024
@jeremystretch jeremystretch added this to the v4.0 milestone Mar 9, 2024
@DanSheps DanSheps linked a pull request Mar 17, 2024 that will close this issue
jeremystretch added a commit that referenced this issue Mar 18, 2024
* Fixes: #13918 - Add facilities field to Location model.

* Stupidly forgot to `git add`

* Fix errant reference to site.

* Misc cleanup

---------

Co-authored-by: Jeremy Stretch <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants