Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VLAN filtering with VLAN groups #13844

Closed
CTV-2023 opened this issue Sep 21, 2023 · 4 comments · Fixed by #14588
Closed

VLAN filtering with VLAN groups #13844

CTV-2023 opened this issue Sep 21, 2023 · 4 comments · Fixed by #14588
Assignees
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@CTV-2023
Copy link

NetBox version

v3.6.2

Python version

3.8

Steps to Reproduce

I have vlans associated to a vlan group. This vlan group scope is a site group. Sites A and B are member of this site group
When I create a new prefix associated to site A, I expect vlans from the vlan group to appear. They don't

On demo website :

  • Create a vlan group "Test-Group", scope type DCIM > site group. Choose a site group, Headquarters for instance
    image

  • Create a vlan and associate it with this vlan group
    image

  • Associate a site to the Headquarters site group, or select one already in it
    image

  • Try to create a prefix with this site. You won't see the vlan
    image

Expected Behavior

When you define a vlan group with site group as a scope, you expect its site members to "inherit" the vlan. I think this part is ok, but you can't select the vlan in prefix creation

Observed Behavior

The vlan is not visible in prefix creation, maybe due to #13721

As a side note, the vlan appears in 802.1q swiching in interfaces for a device member of the site DM-NYC
image

@CTV-2023 CTV-2023 added the type: bug A confirmed report of unexpected behavior in the application label Sep 21, 2023
@jeremystretch
Copy link
Member

jeremystretch commented Sep 21, 2023

I think you're correct in calling this out as a side effect of #13721, however I'm not sure it's a bug. The VLAN field is being filtered by a specific site, to which the desired VLAN is not assigned. This is desired behavior under the condition captured in #13721, but under the condition captured here (where the intent is to infer site assignment via the site group).

Maybe the best solution would be to introduce a separate filter e.g. available_at_site (similar to available_on_device) to filter VLANs according to both site and site group assignments.

As a workaround, you can still use the selector button to the right of the field to select any VLAN, regardless of the selected site.

@jeremystretch jeremystretch added status: under review Further discussion is needed to determine this issue's scope and/or implementation severity: low Does not significantly disrupt application functionality, or a workaround is available labels Sep 21, 2023
@bandwiches
Copy link

Is there a workaround for v3.3.8? I see the same behavior when editing a site prefix where the vlan group is not populating based on the scope unless the vlan group is it's directly scoped to the site itself (not the region or anything else). The selector button does not appear in 3.3.8 as far as I can tell.

@DanSheps DanSheps added status: blocked Another issue or external requirement is preventing implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Dec 15, 2023
@DanSheps
Copy link
Member

Blocked by #14538

@jeremystretch
Copy link
Member

Unblocking as #14538 has been completed

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: blocked Another issue or external requirement is preventing implementation labels Dec 21, 2023
@jeremystretch jeremystretch changed the title Following #13721 - Vlan filtering with vlan groups VLAN filtering with VLAN groups Jan 16, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants