Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add render-config API endpoint for virtual machine #13808

Closed
pkorovin opened this issue Sep 18, 2023 · 6 comments · Fixed by #14287
Closed

Add render-config API endpoint for virtual machine #13808

pkorovin opened this issue Sep 18, 2023 · 6 comments · Fixed by #14287
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@pkorovin
Copy link
Contributor

NetBox version

v3.6.2-dev

Feature type

New functionality

Proposed functionality

Add config template rendering API endpoint for virtual machine.
Config template rendering feature was added in the interface, but there's no corresponding API endpoint: /api/virtualization/virtual-machines/{id}/render-config/

Use case

Allow config template rendering for virtual machines using NetBox API.

Database changes

No response

External dependencies

No response

@pkorovin pkorovin added the type: feature Introduction of new functionality to the application label Sep 18, 2023
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Nov 9, 2023
@jeremystretch jeremystretch added this to the v3.7 milestone Nov 9, 2023
@LuPo
Copy link
Contributor

LuPo commented Nov 16, 2023

Can I take this issue on me?

@jeremystretch
Copy link
Member

@LuPo do you think you'd be able to submit a PR for it by early next week? We're due to release the first v3.7 beta by the end of November, so we'll need to have all milestone issues completed very soon.

@LuPo
Copy link
Contributor

LuPo commented Nov 16, 2023

Yes, I will submit a PR for review today.

@jeremystretch
Copy link
Member

@LuPo awesome, thank you for stepping up!

@pkorovin
Copy link
Contributor Author

Sorry, I missed the moment when the issue was accepted/assigned. Added PR in case it will be helpful.

@LuPo
Copy link
Contributor

LuPo commented Nov 16, 2023

@pkorovin Ah, I have noticed that you have also stepped in just now. I'll close my PR at this point because you have opened the issue :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
3 participants