Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading report without test method yields "Server Error" #13666

Closed
JCWasmx86 opened this issue Sep 3, 2023 · 1 comment · Fixed by #13667
Closed

Uploading report without test method yields "Server Error" #13666

JCWasmx86 opened this issue Sep 3, 2023 · 1 comment · Fixed by #13667
Assignees
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@JCWasmx86
Copy link
Contributor

NetBox version

v3.6.0 (But reproducible in 3.6.1-dev, too)

Python version

3.11

Steps to Reproduce

1.Create a.py:

from extras.reports import Report

class DeviceConnectionsReport(Report):
    description = "Validate the minimum physical connections for each device"
    pass

(Note, the class doesn't have a test method)

2.Upload it as report

Expected Behavior

I expected it to either get an error, that there are no test methods in it, and the ability to delete it without using the CLI.

Observed Behavior

Reality:

<class 'Exception'>

A report must contain at least one test method.

Python version: 3.11.4
NetBox version: 3.6.1-dev
Plugins: None installed

image

Screenshot from develop branch, but reproducible with stable, too

@JCWasmx86 JCWasmx86 added the type: bug A confirmed report of unexpected behavior in the application label Sep 3, 2023
@abhi1693 abhi1693 added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Sep 3, 2023
@JCWasmx86
Copy link
Contributor Author

I will work on this issue, if it is accepted

@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Sep 3, 2023
JCWasmx86 added a commit to JCWasmx86/netbox that referenced this issue Sep 3, 2023
JCWasmx86 added a commit to JCWasmx86/netbox that referenced this issue Sep 3, 2023
JCWasmx86 added a commit to JCWasmx86/netbox that referenced this issue Sep 3, 2023
JCWasmx86 added a commit to JCWasmx86/netbox that referenced this issue Sep 3, 2023
JCWasmx86 added a commit to JCWasmx86/netbox that referenced this issue Sep 3, 2023
JCWasmx86 added a commit to JCWasmx86/netbox that referenced this issue Sep 3, 2023
@jeremystretch jeremystretch added the severity: low Does not significantly disrupt application functionality, or a workaround is available label Sep 5, 2023
JCWasmx86 added a commit to JCWasmx86/netbox that referenced this issue Sep 26, 2023
JCWasmx86 added a commit to JCWasmx86/netbox that referenced this issue Sep 26, 2023
JCWasmx86 added a commit to JCWasmx86/netbox that referenced this issue Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants