Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit to power port overview on device view #13587

Closed
rodvand opened this issue Aug 28, 2023 · 2 comments · Fixed by #14208
Closed

Add unit to power port overview on device view #13587

rodvand opened this issue Aug 28, 2023 · 2 comments · Fixed by #14208
Assignees
@abhi1693
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@rodvand
Copy link
Contributor

rodvand commented Aug 28, 2023

NetBox version

v3.5.8

Feature type

New functionality

Proposed functionality

On the power ports view within a device, add the unit to the Maximum draw and Allocated draw.
From this:
Screenshot 2023-08-28 at 21 14 29

To this
Screenshot 2023-08-28 at 21 14 29

Use case

Just makes it more apparent for users that the unit of power is W.

Database changes

No response

External dependencies

No response
@rodvand rodvand added the type: feature Introduction of new functionality to the application label Aug 28, 2023
@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Nov 6, 2023
@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Nov 8, 2023
@abhi1693 abhi1693 self-assigned this Nov 8, 2023
abhi1693 added a commit that referenced this issue Nov 8, 2023
@abhi1693
adds unit to the power port draw #13587
a373c91
@abhi1693 abhi1693 mentioned this issue Nov 8, 2023
Merged
abhi1693 added a commit that referenced this issue Nov 8, 2023
@abhi1693
review changes #13587
92cdf42
@jeremystretch
Copy link
Member

Does it make sense to replicate the unit for each value in the column? It's always going to be the same; maybe annotating it in the column header would be more efficient. Typically we want to avoid attaching units to numeric data, especially when being exported e.g. as CSV.

@jeremystretch
Copy link
Member

Another option would be to render the unit in the UI, but omit it for CSV export. This would keep the exported data "cleaner" by retaining the native integer format.

abhi1693 added a commit that referenced this issue Nov 9, 2023
@abhi1693
moved units to header #13587
da7ef1f
jeremystretch added a commit that referenced this issue Nov 9, 2023
@abhi1693 @jeremystretch
Adds unit to the power port draw (#14208)
5c27d29 
* adds unit to the power port draw #13587

* review changes #13587

* moved units to header #13587

* Abbreviate unit for consistency with e.g. PowerFeedTable available_power column

---------

Co-authored-by: Jeremy Stretch <[email protected]>
jeremystretch added a commit that referenced this issue Nov 9, 2023
@jeremystretch
Changelog for #12741, #13022, #13587, #13936, #14085, #14117, #14166, #…
351aaf8 
…14182, #14195, #14221
@jeremystretch jeremystretch mentioned this issue Nov 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abhi1693 abhi1693

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds unit to the power port draw netbox-community/netbox
3 participants
@rodvand @abhi1693 @jeremystretch