Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make botocore dependency (AWS S3 backend) optional #12906

Closed
jirutka opened this issue Jun 14, 2023 · 1 comment
Closed

Make botocore dependency (AWS S3 backend) optional #12906

jirutka opened this issue Jun 14, 2023 · 1 comment
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone
v3.6

Comments

@jirutka
Copy link

jirutka commented Jun 14, 2023 •
edited
Loading

NetBox version

v3.5.3

Feature type

Change to existing functionality

Proposed functionality

botocore is a really huge library, it consumes ~88 MiB of disk space. Since the data synchronization feature is optional and S3 is only one of the multiple backends, not all users will need it. The v3.5 release increased the disk size by a factor of 1.5 due to this dependency.

Please consider making this dependency optional.

Use case

Saving disk space / making smaller container images, decreasing the number of dependencies.

Database changes

No response

External dependencies

No response
@jirutka jirutka added the type: feature Introduction of new functionality to the application label Jun 14, 2023
@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Jul 26, 2023
@jeremystretch
Copy link
Member

IMO this should apply to the dulwich library (used for the git backend) as well, and any additional backends we introduce in the future.

@jeremystretch jeremystretch self-assigned this Jul 31, 2023
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Jul 31, 2023
@jeremystretch jeremystretch added this to the v3.6 milestone Jul 31, 2023
jeremystretch added a commit that referenced this issue Jul 31, 2023
@jeremystretch
Initial work on #12906
cb7cf1f
@jeremystretch jeremystretch mentioned this issue Jul 31, 2023
Merged
jeremystretch added a commit that referenced this issue Aug 1, 2023
@jeremystretch
Closes #12906: Make boto3 & dulwich libraries optional (#13324)
c1ca8d5 
* Initial work on #12906

* Catch import errors during backend init

* Tweak error message

* Update requirements & add note to docs
@jeremystretch jeremystretch mentioned this issue Aug 31, 2023
Closed
jeremystretch added a commit that referenced this issue Sep 1, 2023
@jeremystretch
Add #12906 to v3.6.0 changelog
559f65f
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
v3.6
Development

No branches or pull requests
2 participants
@jirutka @jeremystretch