Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Tooltips on Connection buttons #1282

Closed
traveler3468 opened this issue Jun 16, 2017 · 6 comments
Closed

Incorrect Tooltips on Connection buttons #1282

traveler3468 opened this issue Jun 16, 2017 · 6 comments
Labels
type: bug A confirmed report of unexpected behavior in the application

Comments

@traveler3468
Copy link

Issue type: Bug Report

**Python version: 2
**NetBox version: 2.0.4

When making connections I realized that the tooltip's on the connection buttons seem wrong to me. When the interface is connected and it displays the plug icon the tooltip says "Mark Connected" when the the button icon is displaying the circle with a line through it, the tool tip displays "Mark Disconnected"
button bug
button bug2

@traveler3468
Copy link
Author

Update: it also sometimes displays "Mark Planned"

@jeremystretch
Copy link
Member

It should read "mark connected" or "mark planned," to indicate whether the connection has been physically installed. Maybe "mark installed"/"mark planned" is more clear.

@jeremystretch jeremystretch changed the title Bug Report: Incorrect Tooltips on Connection buttons Incorrect Tooltips on Connection buttons Jun 16, 2017
@traveler3468
Copy link
Author

I think the wording is ok but maybe they should be flipped so that when you hover over the circle with the line through it, it displays "mark connected" and vice versa. That to me says that when I hover over it it should tell me what its going to do when I click the button.

@jeremystretch
Copy link
Member

Planned connections are highlighted in blue. Clicking the circle marks an installed connection as planned. Clicking the plug marks a planned connection as installed.

@traveler3468
Copy link
Author

Ahhh, I see. That does make more sense. I didnt even pay attention to the fact that the line turns green when the plug icon is clicked. Green means UP/connected. Am I understanding that correctly?

@jeremystretch
Copy link
Member

Oh, I see what's happening. The Javascript is assigning the title to the wrong element, so you can end up with an icon that says "mark connected" inside a button that says "mark planned" after toggling a connection. Need to fix that.

Green means UP/connected. Am I understanding that correctly?

Yep, but only after toggling a connection. If you reload the page, connections are no longer highlighted.

@jeremystretch jeremystretch added the type: bug A confirmed report of unexpected behavior in the application label Jun 16, 2017
lampwins pushed a commit to lampwins/netbox that referenced this issue Oct 13, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

2 participants