Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not linkify URL when the datasource is local #12112

Closed
abhi1693 opened this issue Mar 31, 2023 · 0 comments
Closed

Do not linkify URL when the datasource is local #12112

abhi1693 opened this issue Mar 31, 2023 · 0 comments
Assignees
@jeremystretch
Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@abhi1693
Copy link
Member

NetBox version

v3.5-beta1

Python version

3.10

Steps to Reproduce

Create a datasrouce with local path

Expected Behavior

On the object page, the URL should not be linkified when type is local

Observed Behavior

URL tries to open a webpage within netbox that does not exist
@abhi1693 abhi1693 added the type: bug A confirmed report of unexpected behavior in the application label Mar 31, 2023
@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Mar 31, 2023
@jeremystretch jeremystretch self-assigned this Mar 31, 2023
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Mar 31, 2023
jeremystretch added a commit that referenced this issue Mar 31, 2023
@jeremystretch
Fixes #12112: Do not link data source URL for local paths
730eb2e
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abhi1693 @jeremystretch