Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectListWidget and ObjectCountsWidget should only take valid ObjectTypes #12103

Closed
kkthxbye-code opened this issue Mar 30, 2023 · 0 comments
Closed

ObjectListWidget and ObjectCountsWidget should only take valid ObjectTypes #12103

kkthxbye-code opened this issue Mar 30, 2023 · 0 comments
Assignees
@jeremystretch
Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@kkthxbye-code
Copy link
Contributor

NetBox version

v.3.5.0-beta1

Python version

3.10

Steps to Reproduce

  1. Create an ObjectList or ObjectCount widget
  2. Select Administration -> Log Entry
  3. Save

Expected Behavior

Shouldn't be able to pick non-netbox native objects (the example one is from django-admin i think). If picked an exception should not be thrown.

Observed Behavior

An exception is thrown for ObjectCountWidget. The widget renders an error for ObjectListWidget.
@kkthxbye-code kkthxbye-code added type: bug A confirmed report of unexpected behavior in the application beta Concerns a bug/feature in a beta release labels Mar 30, 2023
@jeremystretch jeremystretch self-assigned this Mar 31, 2023
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Mar 31, 2023
jeremystretch added a commit that referenced this issue Mar 31, 2023
@jeremystretch
Fixes #12103: Limit the types of objects available for object count &…
8d6c591 
… list widgets
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kkthxbye-code @jeremystretch