Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move non-racked devices to a separate tab under the rack view #11803

Closed
LHBL2003 opened this issue Feb 22, 2023 · 16 comments · Fixed by #13201
Closed

Move non-racked devices to a separate tab under the rack view #11803

LHBL2003 opened this issue Feb 22, 2023 · 16 comments · Fixed by #13201
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@LHBL2003
Copy link

LHBL2003 commented Feb 22, 2023

NetBox version

v3.4.5

Feature type

Change to existing functionality

Proposed functionality

Set the list "Non-Racked Devices" via the rack or as a separate tab/register

image

Maybe even with a signal colour so that you can recognise more quickly that there is a special feature here, which is not the case with every rack.
image

THX to @abhi1693 for the basic image.

Use case

I have been thinking about raising this point for months. But I realise again and again that it is important.

Racks with 42 units are so long that you can't see the "non-racked devices" area on a 24" monitor. That's why you don't pay attention to them. Either they are devices that are not sorted or devices that cannot be installed in a unit, e.g. socket outlets, small devices that are screwed to the rack, e.g. temperature monitors.

Translated with www.DeepL.com/Translator (free version)

Database changes

No response

External dependencies

No response

@LHBL2003 LHBL2003 added the type: feature Introduction of new functionality to the application label Feb 22, 2023
@abhi1693
Copy link
Member

I think non racked devices should simply be moved to a view tab. That way if they exist you see them at the top of the page with a count.

@LHBL2003
Copy link
Author

Do I understand that correctly, is that a counter-suggestion from you? Or does this function exist?

@abhi1693
Copy link
Member

abhi1693 commented Feb 23, 2023

It's a counter suggestion and something once accepted can be implemented natively. I already have a patch that does exactly this in our netbox. It basically moves the list at the bottom to a tab at the top with a count

@jsenecal
Copy link
Contributor

@abhi1693 do you have an issue # for that feature request ?

@abhi1693
Copy link
Member

@jsenecal I'm sorry but I don't follow you.

@jsenecal
Copy link
Contributor

I already have a patch that does exactly this in our netbox. It basically moves the list at the bottom to a tab at the top with a count

@abhi1693
Copy link
Member

abhi1693 commented Feb 23, 2023

Oh, I never opened an issue for this and directly applied the patch in my Netbox code. So, if the suggestion counter to adding the label is accepted, for this issue itself I'll raise the pr

Edit: Here is something to provide more context
image

@jsenecal
Copy link
Contributor

@LHBL2003 If you are happy with what @abhi1693 suggested, please update your proposal to reflect this.

Thank you all,

@jsenecal jsenecal added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Feb 23, 2023
@LHBL2003
Copy link
Author

I think that's a great idea. Maybe you could make sure that the grey background is orange?
Then it would be more eye-catching that there is a special feature that is not present in every rack.

@abhi1693
Copy link
Member

abhi1693 commented Feb 24, 2023

I don't think color would change as that's netbox internal AFAIK. Also, such tabs are used throughout the UI, it should remain consistent as far as UI is considered. Rest as shown in my screenshot is applicable.

@LHBL2003
Copy link
Author

OK

@LHBL2003
Copy link
Author

@jsenecal: Then I would say @abhi1693 suggestion should go into the release function or?

@jeremystretch
Copy link
Member

Is there a real benefit of establishing a tabbed view for these devices as opposed to just linking to the filtered devices list?

@jeremystretch jeremystretch changed the title "Non-Racked Devices" above the rack Move non-racked devices to a separate tab under the rack view May 4, 2023
@JoeIzzard
Copy link
Contributor

I'd rather it be a tab than a link to the Device list so I can easily change back. If it's a link to the device list then I wouldn't have an easy way to tab back to the rack view which I may be switching between several times.

@jsenecal
Copy link
Contributor

Based on #11803 (comment), @abhi1693, I think you already had a fix implemented for this, is that right ?

@abhi1693
Copy link
Member

@jsenecal I don't have any right now, but can submit later if we are accepting this

@abhi1693 abhi1693 self-assigned this Jul 13, 2023
@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Jul 13, 2023
abhi1693 added a commit that referenced this issue Jul 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants