Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the StaticSelect and StaticSelectMultiple form widgets #11765

Closed
jeremystretch opened this issue Feb 16, 2023 · 0 comments
Closed

Remove the StaticSelect and StaticSelectMultiple form widgets #11765

jeremystretch opened this issue Feb 16, 2023 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v3.5

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Remove the custom StaticSelect and StaticSelectMultiple form widget classes, replacing them with their Django-native counterparts, and adjust BootstrapMixin to set CSS classes accordingly.

Justification

We can handle the assignment of the netbox-static-select CSS class within BootstrapMixin, obviating the need for custom widgets.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Feb 16, 2023
@jeremystretch jeremystretch added this to the v3.5 milestone Feb 16, 2023
@jeremystretch jeremystretch self-assigned this Feb 16, 2023
This was referenced Feb 16, 2023
Closed
Merged
jeremystretch added a commit that referenced this issue Feb 16, 2023
@jeremystretch
Closes #11765: Remove StaticSelect & StaticSelectMultiple (#11767)
d6c41fb 
* Remove StaticSelect, StaticSelectMultiple form widgets

* Tag custom ChoiceField, MultipleChoiceField classes for removal in v3.6
jeremystretch added a commit that referenced this issue Feb 16, 2023
@jeremystretch
#11765: Avoid setting netbox-static-select on SelectMultiple with size
30c945a
jeremystretch added a commit that referenced this issue Feb 20, 2023
@jeremystretch
Closes #11765: Remove StaticSelect & StaticSelectMultiple (#11767)
b29f02a 
* Remove StaticSelect, StaticSelectMultiple form widgets

* Tag custom ChoiceField, MultipleChoiceField classes for removal in v3.6
jeremystretch added a commit that referenced this issue Feb 20, 2023
@jeremystretch
#11765: Avoid setting netbox-static-select on SelectMultiple with size
ae0d204
jeremystretch added a commit that referenced this issue Feb 20, 2023
@jeremystretch
Closes #11765: Remove StaticSelect & StaticSelectMultiple (#11767)
b9bd96f 
* Remove StaticSelect, StaticSelectMultiple form widgets

* Tag custom ChoiceField, MultipleChoiceField classes for removal in v3.6
jeremystretch added a commit that referenced this issue Feb 20, 2023
@jeremystretch
#11765: Avoid setting netbox-static-select on SelectMultiple with size
db4e00d
@jeremystretch jeremystretch mentioned this issue Apr 27, 2023
Merged
@benley benley mentioned this issue May 8, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v3.5
Development

No branches or pull requests
1 participant
@jeremystretch